Skip to content

Conversation

@robert-dodier
Copy link

This PR contains 1 commit which resolves SPARK-12663.

For the record, I got a positive response from 2 people when I floated this idea on dev@spark.apache.org on 2015-10-23. Link to archived discussion.

@SparkQA
Copy link

SparkQA commented Jan 6, 2016

Test build #2332 has finished for PR 10611 at commit 8ae7d35.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is too long (see spark style guide). Also, I recommend you use scala's string interpolation rather than manually building the string:

s"previous=$previous, line='$line' "

@thunterdb
Copy link
Contributor

@robert-dodier thanks for your PR. Can you please fix the style issue?

string interpolation instead of pasting string together.
@robert-dodier
Copy link
Author

OK, thanks for the heads-up. I have pushed commit 237677e which addresses the style problems.

@thunterdb
Copy link
Contributor

cc @jkbradley

@jkbradley
Copy link
Member

LGTM pending tests

@SparkQA
Copy link

SparkQA commented Jan 7, 2016

Test build #2340 has finished for PR 10611 at commit 237677e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

Merging with master

Thanks!

@asfgit asfgit closed this in 6b6d02b Jan 7, 2016
@robert-dodier robert-dodier deleted the loadlibsvmfile-error-msg-branch branch March 14, 2018 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants