-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-12536] [SQL] Added "[]" in Explain Outputs For Empty LocalRelation and LocalTableScan #10646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@cloud-fan @marmbrus Hopefully, my understanding is right. Feel free to let me know if the fix needs any change. Thank you! |
|
Test build #48946 has finished for PR 10646 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a better way is to change this if to if seq.nonEmpty && seq.toSet.subsetOf(children.toSet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Will do!
|
Test build #49091 has finished for PR 10646 at commit
|
|
Test build #49092 has finished for PR 10646 at commit
|
|
retest this please. |
|
Test build #49152 has finished for PR 10646 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these import changes are irrelevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I just saw these useless imports in this file. Do you want me to keep them unchanged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, it's fine to remove useless imports.
|
LGTM |
|
Thank you for your help! Sorry for wasting you a lot of time on it! @cloud-fan |
|
@gatorsmile I'm actually not sure whether the new format is more clear. Do you mind closing this? Thanks. |
|
Sure, let me close it. |
The filter
Filter (False)generates an emptyLocalRelationinSimplifyFilters. In the currentExplain, the optimized and physical plans look confusing.For example,
After the fix, the Optimized Logical Plan and Physical Plan are changed to
The original PR is: #10494