Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This PR fixes some typos in the following documentation files.

  • NOTICE, configuration.md, and hardware-provisioning.md.

How was the this patch tested?

manual tests

Author: Dongjoon Hyun dongjoon@apache.org

@srowen
Copy link
Member

srowen commented Feb 21, 2016

That's fine. The NOTICE typos are actually from the upstream source notices, so I guess we really technically don't care / shouldn't change them, but I'm OK with it.

@srowen
Copy link
Member

srowen commented Feb 21, 2016

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Feb 21, 2016

Test build #51629 has finished for PR 11289 at commit a73a9e2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Oh, thank you, @srowen .

@rxin
Copy link
Contributor

rxin commented Feb 21, 2016

I don't think we should change the NOTICE file. Can you reset the change for that?

@dongjoon-hyun
Copy link
Member Author

Oh, sure. No problem. Only for NOTICE, right?

@rxin
Copy link
Contributor

rxin commented Feb 21, 2016

Yes only notice. Thanks.

…ing.md`.

This PR fixes some typos in the following documentation files.
 * `configuration.md`, and `hardware-provisioning.md`.

Author: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun
Copy link
Member Author

Thank you, @rxin. I remove the change on NOTICE file and rebased it now.

@dongjoon-hyun dongjoon-hyun changed the title [MINOR][DOCS] Fix typos in NOTICE, configuration.md, and hardware-provisioning.md [MINOR][DOCS] Fix typos in configuration.md and hardware-provisioning.md Feb 21, 2016
@rxin
Copy link
Contributor

rxin commented Feb 21, 2016

Thanks - I've merged this.

@asfgit asfgit closed this in 03e62aa Feb 21, 2016
@dongjoon-hyun
Copy link
Member Author

Thank you for merging, @rxin .

@dongjoon-hyun dongjoon-hyun deleted the minor_fix_typos_notice_and_confdoc branch March 3, 2016 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants