[SPARK-13486][SQL] Move SQLConf into an internal package #11363
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Make sure we start with the default test configs even after clear | ||
| TestSQLContext.overrideConfs.map { | ||
| TestSQLContext.overrideConfs.foreach { |
Contributor
Author
There was a problem hiding this comment.
found a potential bug here and fixed it
Contributor
Author
|
cc @cloud-fan for review |
|
Test build #51936 has finished for PR 11363 at commit
|
|
Test build #51937 has finished for PR 11363 at commit
|
|
Test build #51942 has finished for PR 11363 at commit
|
| import org.apache.spark.executor.DataReadMethod | ||
| import org.apache.spark.sql.{SQLConf, SQLContext} | ||
| import org.apache.spark.sql.internal.SQLConf | ||
| import org.apache.spark.sql.SQLContext |
Contributor
There was a problem hiding this comment.
Import order is wrong here.
Contributor
There was a problem hiding this comment.
Hm, weird, Scala style linter passed...
I think it's wrong because classes/objects inside the sql package should be put before those in sql.internal package.
Anyway, let's put it aside as long as the linter passes.
Contributor
|
LGTM |
Contributor
|
Merged to master. |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch moves SQLConf into org.apache.spark.sql.internal package to make it very explicit that it is internal. Soon I will also submit more API work that creates implementations of interfaces in this internal package.
How was this patch tested?
If it compiles, then the refactoring should work.