Skip to content

Conversation

@JoshRosen
Copy link
Contributor

Our nightly doc snapshot builds are failing due to some issue involving the Guava Stopwatch constructor:

[error] /home/jenkins/workspace/spark-master-docs/spark/core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala:496: constructor Stopwatch in class Stopwatch cannot be accessed in class CoarseMesosSchedulerBackend
[error]     val stopwatch = new Stopwatch()
[error]                     ^

This Stopwatch constructor was deprecated in newer versions of Guava (google/guava@fd0cbc2) and it's possible that some classpath issues affecting Unidoc could be causing this to trigger compilation failures.

In order to work around this issue, this patch removes this use of Stopwatch since we don't use it anywhere else in the Spark codebase.

@JoshRosen
Copy link
Contributor Author

/cc @andrewor14 for review.

@JoshRosen JoshRosen changed the title [SPARK-13501] Remove use of Guava Stopwatch. [SPARK-13501] Remove use of Guava Stopwatch Feb 25, 2016
@andrewor14
Copy link
Contributor

lgtm

@andrewor14
Copy link
Contributor

This passed the mesos tests already. Merging into master.

@asfgit asfgit closed this in f2cfafd Feb 26, 2016
@SparkQA
Copy link

SparkQA commented Feb 26, 2016

Test build #52001 has finished for PR 11376 at commit ecc21ac.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen JoshRosen deleted the remove-stopwatch branch February 26, 2016 01:15
@srowen
Copy link
Member

srowen commented Feb 26, 2016

+1 Stopwatch has been problematic for me since the two ways of making it (constructor, factory) only both exist in a few versions. So it's frequently a problem in both directions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants