Skip to content

Conversation

@GayathriMurali
Copy link
Contributor

What changes were proposed in this pull request?

Add export/import for all estimators and transformers(which have Scala implementation) under pyspark/ml/classification.py.

JIRA : https://issues.apache.org/jira/browse/SPARK-13034

How was this patch tested?

Unit tests added to tests.py

…hich have Scala implementation) under pyspark/ml/classification.py

…hich have Scala implementation) under pyspark/ml/classification.py
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@wangmiao1981
Copy link
Contributor

Hi Gayathri,

I put my comments in the JIRA about 2 weeks ago and worked with Yanbo on putting some code.

Can we work together to get it merged? I can close my PR if needed. By the way, what is the best way to notify people that I am working on some JIRA and we will not spend time on the same JIRA in the future.

Thanks!

Miao

@GayathriMurali
Copy link
Contributor Author

@wangmiao1981 Sorry about that. I did see your comments and since there wasnt any pull request, I went ahead and sent one. We could definitely work together to get this merged.

@wangmiao1981
Copy link
Contributor

@GayathriMurali Thanks! I see you add one more classification other than logisticregression and navie bayes. When I was working on my code base, that classifier doesn't have scala import/export support yet. I think yours is more recent than mine.

@GayathriMurali
Copy link
Contributor Author

@yanboliang Can you please help review this PR?

@jkbradley
Copy link
Member

@GayathriMurali @wangmiao1981 It will be great to add persistence for LogisticRegression and NaiveBayes. The other algorithms will need to wait since they do not yet have Scala support for persistence. Could you please reconcile your 2 PRs? It would be great to close one and have both of you collaborate on 1 PR. Thanks!

@GayathriMurali
Copy link
Contributor Author

@wangmiao1981 I can close my PR and we can may be work on yours?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants