Skip to content

Conversation

@zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

add nonEmpty method to RDD and JavaRDD.
It may be more convenient to use nonEmpty method in some cases.

How was this patch tested?

manual tests

@SparkQA
Copy link

SparkQA commented Mar 18, 2016

Test build #53536 has finished for PR 11823 at commit aacf266.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

/**
* @return false if and only if the RDD contains no elements at all. Note that an RDD
* may be empty even when it has at least 1 partition.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't worth adding. I know Scala has both.
An API change would certainly need a JIRA, but this should be closed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will close it. but I think it may be useful to add some methods like nonEmpty/takeRight...

@zhengruifeng zhengruifeng deleted the nonEmpty branch April 10, 2016 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants