-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-14021][SQL] custom context support for SparkSQLEnv #11843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #53613 has finished for PR 11843 at commit
|
654397e to
864e1b6
Compare
|
Test build #53614 has finished for PR 11843 at commit
|
|
|
||
| private def readContextClassFromConf(sparkConf: SparkConf): Class[_ <: HiveContext] = { | ||
| val className = | ||
| sparkConf.get("spark.sql.context.class", "org.apache.spark.sql.hive.HiveContext") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of hard code, can we make it as classOf[HiveContext].getName()?
|
Test build #54020 has finished for PR 11843 at commit
|
|
cc @rxin @liancheng |
|
cc @yhuai , this is critical for our own customized |
|
HiveContext is going to be deprecated in Spark 2.0. Please see https://issues.apache.org/jira/browse/SPARK-13485 I don't think it makes sense to merge this at this point. If you need this, you should do something once SparkSession is introduced. |
|
Let's close this PR since |
What changes were proposed in this pull request?
This is to create a custom context for command
bin/spark-sqlandsbin/start-thriftserver. Any context that is derived fromHiveContextis acceptable. User need to configure the class name of custom context in a config ofspark.sql.context.class, and make sure the class in classpath. This is to provide a more elegant way for custom configurations and changes for infrastructure team.How was this patch tested?
Added a unit test in
CliSuiteto track this.cc @chenghao-intel