[SPARK-14134] [core] [test-maven] Change the package name used for shading classes.

[vanzin]

The current package name uses a dash, which is a little weird but seemed
to work. That is, until a new test tried to mock a class that references
one of those shaded types, and then things started failing.

Most changes are just noise to fix the logging configs.

For reference, SPARK-8815 also raised this issue, although at the time it
did not cause any issues in Spark, so it was not addressed.

[srowen]

For total avoidance of trouble, is org.sparkproject safer? or are you sure underscores are more OK than hyphens? BTW you could consider this PR as a resolution for SPARK-8815 too.

[vanzin]

Underscores are ok (they're not an operator like - is).

[vanzin]

retest this please

[SparkQA]

Test build #54073 has finished for PR 11941 at commit 9ecbafb.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[vanzin]

Weird error, seems unrelated. retest this please.

[SparkQA]

Test build #54067 has finished for PR 11941 at commit 9ecbafb.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[vanzin]

hmm different test failure that also looks unrelated. retest this please

[SparkQA]

Test build #54083 has finished for PR 11941 at commit 9ecbafb.

• This patch fails from timeout after a configured wait of 250m.
• This patch merges cleanly.
• This patch adds no public classes.

[vanzin]

sql test was stuck. retest this please.

[SparkQA]

Test build #54099 has finished for PR 11941 at commit 9ecbafb.

• This patch fails from timeout after a configured wait of 250m.
• This patch merges cleanly.
• This patch adds no public classes.

[vanzin]

wtf. retest this please.

[SparkQA]

Test build #54132 has finished for PR 11941 at commit 9ecbafb.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #54137 has finished for PR 11941 at commit 9ecbafb.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[vanzin]

this is the same flaky test that's failing in other places with maven... let me see if it's easy to fix.

[zsxwing]

@vanzin I fixed it in #11895

[zsxwing]

However, #11895 is blocked by #11940. It can not pass tests :(

[vanzin]

Cool, guess I'll wait for those, thanks.

[vanzin]

retest this please

[SparkQA]

Test build #54242 has finished for PR 11941 at commit 9ecbafb.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[zsxwing]

You also need to update the flume's log4j files as it's moved back now.

[SparkQA]

Test build #54332 has finished for PR 11941 at commit 81af47b.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[vanzin]

I'm gonna close this for now since #11796 is passing without this patch... no idea how.

[vanzin]

Reopened since I'm running into this problem locally, and the fix makes things more correct anyway.

[SparkQA]

Test build #55138 has finished for PR 11941 at commit 21568f9.

• This patch fails to build.
• This patch merges cleanly.
• This patch adds no public classes.

[vanzin]

retest this please

[SparkQA]

Test build #55141 has finished for PR 11941 at commit 21568f9.

• This patch fails to build.
• This patch merges cleanly.
• This patch adds no public classes.

[vanzin]

@JoshRosen these tests are not happy with the build jdk; are you still in the process of fixing things?

[JoshRosen]

Argh, I forgot to do the $PATH prepending in the PRB... forget that those jobs' confs are managed via a different system than the rest of the Jenkins confs. Applying a manual conf. change to those jobs now.

[JoshRosen]

Jenkins, retest this please.

[SparkQA]

Test build #55148 has finished for PR 11941 at commit 21568f9.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[vanzin]

Since this was reviewed / tested before, I'll merge it in the morning unless someone objects (or beats me to it).

[JoshRosen]

LGTM, so I'm going to merge this now into 2.0. Thanks Marcelo!