[SPARK-14278][SQL] Initialize columnar batch with proper memory mode#12070
Closed
sameeragarwal wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-14278][SQL] Initialize columnar batch with proper memory mode#12070sameeragarwal wants to merge 1 commit intoapache:masterfrom
sameeragarwal wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
cc @marmbrus |
Contributor
|
LGTM |
| } | ||
|
|
||
| columnarBatch = ColumnarBatch.allocate(batchSchema); | ||
| columnarBatch = ColumnarBatch.allocate(batchSchema, memMode); |
Contributor
There was a problem hiding this comment.
Can you avoid this class of problem in the future by simply removing the single-argument allocate method or the default value of memMode?
Member
Author
There was a problem hiding this comment.
I considered it, but the single-argument allocate is currently also used in DataSourceStrategy. Can we change it there? cc @nongli
|
Test build #54542 has finished for PR 12070 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes a minor bug in the record reader constructor that was possibly introduced during refactoring.
How was this patch tested?
N/A