Skip to content

[MINOR][DOCS] Use multi-line JavaDoc comments in Scala code.#12130

Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:use_multiine_javadoc_comments
Closed

[MINOR][DOCS] Use multi-line JavaDoc comments in Scala code.#12130
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:use_multiine_javadoc_comments

Conversation

@dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This PR aims to fix all Scala-Style multiline comments into Java-Style multiline comments in Scala codes.
(All comment-only changes over 77 files: +786 lines, −747 lines)

How was this patch tested?

Manual.

@dongjoon-hyun
Copy link
Member Author

Could you review this PR, @rxin ?

@SparkQA
Copy link

SparkQA commented Apr 2, 2016

Test build #54770 has finished for PR 12130 at commit 9c06d60.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

org.apache.spark.sql.execution.streaming.state.StateStoreSuite.maintenance failure again.
It's a timeout error, should we increase the timeout for the test?

@dongjoon-hyun
Copy link
Member Author

Rebased to trigger Jenkins test.

@SparkQA
Copy link

SparkQA commented Apr 2, 2016

Test build #54779 has finished for PR 12130 at commit 51ab3ba.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 2, 2016

Test build #2734 has finished for PR 12130 at commit 51ab3ba.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Apr 3, 2016

Thanks - merging in master.

@rxin
Copy link
Contributor

rxin commented Apr 3, 2016

BTW in the future for changes this size we should create a JIRA ticket.

Can you look into whether it is possible to create a scalastyle rule for this so we don't do the scaladoc style docs in the future?

@asfgit asfgit closed this in 4a6e78a Apr 3, 2016
@dongjoon-hyun
Copy link
Member Author

Thank you, @rxin . I see. I'll create a JIRA for large size patch .
And, for creating new ScalaStyle rule to enforce this seems a good idea.
I'll take a look at that tomorrow. Thanks again.

@dongjoon-hyun
Copy link
Member Author

Hi, @rxin .
I made a new PR for ScalaStyle rule enforcement ( #12221 ).

@dongjoon-hyun dongjoon-hyun deleted the use_multiine_javadoc_comments branch April 23, 2016 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants