Skip to content

[SPARK-14355][BUILD] Fix typos in Exception/Testcase/Comments and static analysis results#12139

Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-14355
Closed

[SPARK-14355][BUILD] Fix typos in Exception/Testcase/Comments and static analysis results#12139
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-14355

Conversation

@dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This PR contains the following 5 types of maintenance fix over 59 files (+94 lines, -93 lines).

  • Fix typos(exception/log strings, testcase name, comments) in 44 lines.
  • Fix lint-java errors (MaxLineLength) in 6 lines. (New codes after SPARK-14011)
  • Use diamond operators in 40 lines. (New codes after SPARK-13702)
  • Fix redundant semicolon in 5 lines.
  • Rename class InferSchemaSuite to CSVInferSchemaSuite in CSVInferSchemaSuite.scala.

How was this patch tested?

Manual and pass the Jenkins tests.

…tic analysis results

* Fix typos(exception strings, testcase name, comments) in 44 lines.
* Fix lint-java errors (MaxLineLength) in 6 lines.
* Use diamond operators in 40 lines.
* Fix redundant semicolon in 5 lines.
* Rename class `InferSchemaSuite` to `CSVInferSchemaSuite` in CSVInferSchemaSuite.scala.
@srowen
Copy link
Member

srowen commented Apr 4, 2016

LGTM

@dongjoon-hyun
Copy link
Member Author

Thank you, @srowen .

@SparkQA
Copy link

SparkQA commented Apr 4, 2016

Test build #54815 has finished for PR 12139 at commit f173495.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Apr 4, 2016

Thanks - merging in master.

@asfgit asfgit closed this in 3f749f7 Apr 4, 2016
@dongjoon-hyun
Copy link
Member Author

Thank you, @rxin .

@dongjoon-hyun dongjoon-hyun deleted the SPARK-14355 branch May 12, 2016 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants