Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Apr 5, 2016

What changes were proposed in this pull request?

Take 2: avoid None.get NoSuchElementException in favor of more descriptive IllegalArgumentException if a non-existent checkpoint dir is used without a SparkContext

How was this patch tested?

Jenkins test plus new test for this particular case

…ptive IllegalArgumentException if a non-existent checkpoint dir is used without a SparkContext
@srowen
Copy link
Member Author

srowen commented Apr 5, 2016

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Apr 5, 2016

Test build #54980 has finished for PR 12174 at commit 320c932.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Apr 5, 2016

retest this please

@zsxwing
Copy link
Member

zsxwing commented Apr 5, 2016

LGTM pending tests

@SparkQA
Copy link

SparkQA commented Apr 5, 2016

Test build #55023 has finished for PR 12174 at commit 320c932.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Apr 5, 2016

retest this please

@SparkQA
Copy link

SparkQA commented Apr 6, 2016

Test build #55045 has finished for PR 12174 at commit 320c932.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Apr 6, 2016

Thanks, merging to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants