Skip to content

[SPARK-14128][SQL] Alter table DDL followup#12186

Closed
andrewor14 wants to merge 1 commit intoapache:masterfrom
andrewor14:alter-table-ddl-followup
Closed

[SPARK-14128][SQL] Alter table DDL followup#12186
andrewor14 wants to merge 1 commit intoapache:masterfrom
andrewor14:alter-table-ddl-followup

Conversation

@andrewor14
Copy link
Contributor

What changes were proposed in this pull request?

This is just a followup to #12121, which implemented the alter table DDLs using the SessionCatalog. Specially, this corrects the behavior of setting the location of a datasource table. For datasource tables, we need to set the locationUri in addition to the path entry in the serde properties. Additionally, changing the location of a datasource table partition is not allowed.

How was this patch tested?

DDLSuite

@andrewor14
Copy link
Contributor Author

@yhuai

@SparkQA
Copy link

SparkQA commented Apr 5, 2016

Test build #55032 has finished for PR 12186 at commit 181ae14.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor Author

Build is broken. retest this please

@SparkQA
Copy link

SparkQA commented Apr 5, 2016

Test build #55040 has finished for PR 12186 at commit 181ae14.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor Author

what... retest this please?

@SparkQA
Copy link

SparkQA commented Apr 6, 2016

Test build #55048 has finished for PR 12186 at commit 181ae14.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Apr 6, 2016

LGTM. Merging to master.

@asfgit asfgit closed this in adbfdb8 Apr 6, 2016
@andrewor14 andrewor14 deleted the alter-table-ddl-followup branch April 6, 2016 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants