[SPARK-14424][BUILD][DOCS] Update the build docs to switch from assembly to package and add a no…#12197
Closed
holdenk wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
…te in spark-class if we can't find the required target
|
Test build #55088 has finished for PR 12197 at commit
|
bin/spark-class
Outdated
| if [ ! -d "$SPARK_JARS_DIR" ] && [ -z "$SPARK_TESTING$SPARK_SQL_TESTING" ]; then | ||
| echo "Failed to find Spark jars directory ($SPARK_JARS_DIR)." 1>&2 | ||
| echo "You need to build Spark before running this program." 1>&2 | ||
| echo "Note: In Spark 2.0 the required build target has changed from \"assembly\" to \"package\"" 1>&2 |
Member
There was a problem hiding this comment.
This looks OK though I suppose this message can be shortened to just directly state that you need to "build Spark with target 'package' before running this program". Looks like mvn package still works so that's all fine.
Contributor
There was a problem hiding this comment.
+1, "assembly" was never valid in maven.
|
Test build #55128 has finished for PR 12197 at commit
|
| PySpark on YARN is only supported if the jar is built with Maven. Further, there is a known problem | ||
| with building this assembly jar on Red Hat based operating systems (see [SPARK-1753](https://issues.apache.org/jira/browse/SPARK-1753)). If you wish to | ||
| run PySpark on a YARN cluster with Red Hat installed, we recommend that you build the jar elsewhere, | ||
| then ship it over to the cluster. We are investigating the exact cause for this. |
Contributor
There was a problem hiding this comment.
hah, I guess the investigation never happened.
Contributor
|
LGTM merging into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change our build docs & shell scripts to that developers are aware of the change from "assembly" to "package"
How was this patch tested?
Manually ran ./bin/spark-shell after ./build/sbt assembly and verified error message printed, ran new suggested build target and verified ./bin/spark-shell runs after this.