[SPARK-14436][sql] Make JavaDatasetAggregatorSuiteBase public.#12212
Closed
vanzin wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-14436][sql] Make JavaDatasetAggregatorSuiteBase public.#12212vanzin wants to merge 2 commits intoapache:masterfrom
vanzin wants to merge 2 commits intoapache:masterfrom
Conversation
added 2 commits
April 6, 2016 12:13
Without this, unit tests that extend that class fail for me locally on maven, because JUnit tries to run methods in that class and gets an IllegalAccessError.
| return ds.groupByKey( | ||
| new MapFunction<Tuple2<String, Integer>, String>() { | ||
| @Override | ||
| public String call(Tuple2<String, Integer> value) throws Exception { |
Member
There was a problem hiding this comment.
Although you can remove "throws Exception" here while you're at it, it is not important. LGTM as is
|
Test build #55139 has finished for PR 12212 at commit
|
Contributor
|
LGTM |
Contributor
Author
|
Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, unit tests that extend that class fail for me locally
on maven, because JUnit tries to run methods in that class and gets
an IllegalAccessError.