[SPARK-14298] [ML] [MLlib] Add unit test for EM LDA disable checkpointing#12286
[SPARK-14298] [ML] [MLlib] Add unit test for EM LDA disable checkpointing#12286yanboliang wants to merge 2 commits intoapache:masterfrom
Conversation
|
Test build #55474 has finished for PR 12286 at commit
|
|
Test build #55475 has finished for PR 12286 at commit
|
|
We could maybe make this a more complete test and actually check that their are no checkpoint files generated? Although that might be over kill. |
|
@holdenk Thanks for your comments! Actually |
|
@yanboliang that makes sense. I was thinking maybe checking the actual checkpoint directory to catch anything else (or even just clearing the checkpoint directory so checkpointing fails), but if |
|
@holdenk I agree with you, but I'm worried it could fail if checkpoint deletion/cleanup does not happen quickly enough across tests in this suite. I'd prefer to leave it as is. |
|
@yanboliang Thanks! LGTM |
What changes were proposed in this pull request?
This is follow up for #12089, add unit test for EM LDA which test disable checkpointing when set
checkpointInterval = -1.How was this patch tested?
unit test.
cc @jkbradley