[SPARK-14547] Avoid DNS resolution for reusing connections#12315
Closed
rxin wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-14547] Avoid DNS resolution for reusing connections#12315rxin wants to merge 2 commits intoapache:masterfrom
rxin wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
I downgraded this logging level from info to trace.
Contributor
There was a problem hiding this comment.
I think it's more useful to log a warning if this time is greater than say 2 seconds.
|
Test build #55566 has finished for PR 12315 at commit
|
|
Test build #2774 has finished for PR 12315 at commit
|
|
Test build #2775 has finished for PR 12315 at commit
|
Contributor
|
lgtm |
Contributor
Author
|
OK updated. |
|
Test build #55625 has finished for PR 12315 at commit
|
|
Test build #2780 has finished for PR 12315 at commit
|
Contributor
Author
|
Alright going to merge this. |
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Apr 13, 2016
| final long preResolveHost = System.nanoTime(); | ||
| final InetSocketAddress resolvedAddress = new InetSocketAddress(remoteHost, remotePort); | ||
| final long hostResolveTimeMs = (System.nanoTime() - preResolveHost) / 1000000; | ||
| if (hostResolveTimeMs > 2000) { |
Contributor
There was a problem hiding this comment.
Should the value of 2000 be configurable ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch changes the connection creation logic in the network client module to avoid DNS resolution when reusing connections.
How was this patch tested?
Testing in production. This is too difficult to test in isolation (for high fidelity unit tests, we'd need to change the DNS resolution behavior in the JVM).