[SPARK-14605][ML][PYTHON] Changed Python to use unicode UIDs for spark.ml Identifiable#12368
Closed
jkbradley wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-14605][ML][PYTHON] Changed Python to use unicode UIDs for spark.ml Identifiable#12368jkbradley wants to merge 3 commits intoapache:masterfrom
jkbradley wants to merge 3 commits intoapache:masterfrom
Conversation
Member
Author
|
Test build #55739 has finished for PR 12368 at commit
|
Contributor
|
@jkbradley this looks great, thanks! |
python/pyspark/ml/pipeline.py
Outdated
Contributor
There was a problem hiding this comment.
shouldn't you have this line in the file above?
Contributor
|
@jkbradley sorry for the delay, I have one comment. Also, you have some merging issues. |
jkbradley
force-pushed
the
python-uid-unicode
branch
from
b4ac68e to
5b5860a
Compare
Member
Author
|
Thanks, updated! |
|
Test build #55841 has finished for PR 12368 at commit
|
|
Test build #2794 has finished for PR 12368 at commit
|
Member
Author
|
I'll go ahead and merge this with master. |
lw-lin
pushed a commit
to lw-lin/spark
that referenced
this pull request
Apr 20, 2016
…k.ml Identifiable ## What changes were proposed in this pull request? Python spark.ml Identifiable classes use UIDs of type str, but they should use unicode (in Python 2.x) to match Java. This could be a problem if someone created a class in Java with odd unicode characters, saved it, and loaded it in Python. This PR: Use unicode everywhere in Python. ## How was this patch tested? Updated persistence unit test to check uid type Author: Joseph K. Bradley <joseph@databricks.com> Closes apache#12368 from jkbradley/python-uid-unicode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Python spark.ml Identifiable classes use UIDs of type str, but they should use unicode (in Python 2.x) to match Java. This could be a problem if someone created a class in Java with odd unicode characters, saved it, and loaded it in Python.
This PR: Use unicode everywhere in Python.
How was this patch tested?
Updated persistence unit test to check uid type