[SPARK-14711] [BUILD] Examples jar not a part of distribution.#12476
Closed
markgrover wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-14711] [BUILD] Examples jar not a part of distribution.#12476markgrover wants to merge 2 commits intoapache:masterfrom
markgrover wants to merge 2 commits intoapache:masterfrom
Conversation
|
Test build #56114 has finished for PR 12476 at commit
|
Member
Author
|
@vanzin I'd appreciate if you could review this. Thanks! |
examples/pom.xml
Outdated
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-jar-plugin</artifactId> | ||
| <executions> |
Contributor
There was a problem hiding this comment.
Why do you need to add this execution? There's nothing in the "test jar" for the examples module.
Member
Author
There was a problem hiding this comment.
Good point, I will take it out. Thanks.
|
Test build #56149 has finished for PR 12476 at commit
|
Contributor
|
LGTM, merging to master. |
Member
Author
|
Thanks, Marcelo. Much appreciated! |
lw-lin
pushed a commit
to lw-lin/spark
that referenced
this pull request
Apr 20, 2016
## What changes were proposed in this pull request? Move the spark-examples.jar from being in examples/target to examples/target/scala-2.11/jars ## How was this patch tested? Built distribution to make sure examples jar was being included in the tarball. Ran run-example to make sure examples were run. Author: Mark Grover <mark@apache.org> Closes apache#12476 from markgrover/spark-14711.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move the spark-examples.jar from being in examples/target to examples/target/scala-2.11/jars
How was this patch tested?
Built distribution to make sure examples jar was being included in the tarball.
Ran run-example to make sure examples were run.