Skip to content

Python sqlContext.getConf() add one argument version#12478

Closed
mathieulongtin wants to merge 7 commits intoapache:branch-1.6from
mathieulongtin:pyfixgetconf
Closed

Python sqlContext.getConf() add one argument version#12478
mathieulongtin wants to merge 7 commits intoapache:branch-1.6from
mathieulongtin:pyfixgetconf

Conversation

@mathieulongtin
Copy link

What changes were proposed in this pull request?

In Python, sqlContext.getConf didn't allow getting the system default (getConf with one parameter).

Now the following are supported:

sqlContext.getConf(confName)  # System default if not locally set, this is new
sqlContext.getConf(confName, myDefault)  # myDefault if not locally set

I also added doctests to this function

How was this patch tested?

Manually, but doctests were added.

Cherrypick commit 16a74ac.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@rxin
Copy link
Contributor

rxin commented Apr 18, 2016

Can you update the pull request title to include more information?

@rxin
Copy link
Contributor

rxin commented Apr 18, 2016

Also why do we need to introduce csv dependency?

@mathieulongtin mathieulongtin changed the title Pyfixgetconf Python sqlContext.getConf() add one argument version Apr 18, 2016
@mathieulongtin
Copy link
Author

Sorry, just cherry-pick the last commit on that branch. I'm new using git with large project that change all the time.

@mathieulongtin
Copy link
Author

Nevermind, somehow picked the wrong branch entirely.

@mathieulongtin mathieulongtin deleted the pyfixgetconf branch April 19, 2016 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants