[SPARK-14594][SPARKR] check execution return status code#12622
Closed
felixcheung wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-14594][SPARKR] check execution return status code#12622felixcheung wants to merge 1 commit intoapache:masterfrom
felixcheung wants to merge 1 commit intoapache:masterfrom
Conversation
|
Test build #56741 has finished for PR 12622 at commit
|
Contributor
|
LGTM. It'll be good to know more information though. Maybe we can add a log message for the JVM with an exit handler or something like that ? |
Member
Author
|
JVM addShutdownHook is being added for a couple for things and they have logging, for example: But unfortunately they are not guaranteed to be called if the process is terminated abruptly. If we are concerned I think we should get a specific repro step to check if we have logging for that case, if possible. |
Contributor
|
Ok - this is good for now. I'll merge this PR and we can revisit this if we have a better repro. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When JVM backend fails without going proper error handling (eg. process crashed), the R error message could be ambiguous.
This change attempts to make it more clear (however, one would still need to investigate why JVM fails)
How was this patch tested?
manually