[SPARK-14853] [SQL] Support LeftSemi/LeftAnti in SortMergeJoinExec#12668
Closed
davies wants to merge 7 commits intoapache:masterfrom
Closed
[SPARK-14853] [SQL] Support LeftSemi/LeftAnti in SortMergeJoinExec#12668davies wants to merge 7 commits intoapache:masterfrom
davies wants to merge 7 commits intoapache:masterfrom
Conversation
|
Test build #56921 has finished for PR 12668 at commit
|
|
Test build #56923 has finished for PR 12668 at commit
|
|
Test build #56941 has finished for PR 12668 at commit
|
Contributor
|
@hvanhovell want to review? |
|
Test build #56976 has finished for PR 12668 at commit
|
|
Test build #56977 has finished for PR 12668 at commit
|
| * - Sort merge: if the matching join keys are sortable. | ||
| * | ||
| * If there is no joining keys, Join implementations are chosen with the following precedence: | ||
| * - BroadcastNestedLoopJoin: if one side of the join could be broadcasted |
Contributor
There was a problem hiding this comment.
NIT: can be broadcasted
Contributor
|
@davies I left a few comments. Only one of them is more serious. |
|
Test build #57006 has finished for PR 12668 at commit
|
|
Test build #2886 has finished for PR 12668 at commit
|
Contributor
|
LGTM |
Contributor
Author
|
Merging this into master, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR update SortMergeJoinExec to support LeftSemi/LeftAnti, so it could support all the join types, same as other three join implementations: BroadcastHashJoinExec, ShuffledHashJoinExec,and BroadcastNestedLoopJoinExec.
This PR also simplify the join selection in SparkStrategy.
How was this patch tested?
Added new tests.