-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-14989][BUILD] Upgrade Jackson from 2.5.3 to 2.7.3 #12766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #57282 has finished for PR 12766 at commit
|
|
/cc @srowen |
| opencsv-2.3.jar | ||
| oro-2.0.8.jar | ||
| paranamer-2.6.jar | ||
| paranamer-2.3.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird that this version went down
|
I like it. The only looming problem is whether this works in the context of Hadoop classes which may have a different Jackson version. As long as 2.7 wins, it probably works, but it bears testing. Shading could help if there's a problem. This dependency is always a little problematic but worth pushing forward. |
|
Actually may be fine. Hadoop actually includes Jackson 1.x, and the things pulling in 2.x besides Spark seem to be dropwizard metrics and Scala. Those may be much more manageable |
|
My impression is that Jackson's backwards-compatibility story is good. It looks like Jackson 2.7.4 was just released a few hours ago, so maybe we should wait a day and upgrade straight to that instead: https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.7.4 @cowtowncoder, since you mentioned wanting to get the various "big data" frameworks to upgrade to newer Jackson versions, do you know of any compatibility issues that we should be aware of? Just thought I'd ask since you might have received feedback from other projects that are performing the same upgrade. |
|
@JoshRosen yes, thank you for following up on this! On compatibility: there were some issues with 2.7.0 - 2.7.2, regarding type resolution, most of which were fixed with 2.7.3. 2.6.x had one compatibility issue over 2.5.x that users have had problems with (wrt So with Spark 2.0, I would recommend going with 2.7.4. One additional thing that may make 2.7 best choice is that we once again have active owner for Scala module, and there has been progress in getting some long-time-open bugs fixed for 2.7.4. |
|
Closing this PR for now since this upgrade was performed in a different PR while I was away. |
This patch upgrades Jackson from 2.5.3 to 2.7.3. I'd like to upgrade now in order to take advantage of new performance improvements and features, as well as to be better-prepared for when we'll want to upgrade for Scala 2.12 support.