Skip to content

[SPARK-15004][SQL] Remove zookeeper service discovery code in thrift-server#12780

Closed
rxin wants to merge 2 commits intoapache:masterfrom
rxin:SPARK-15004
Closed

[SPARK-15004][SQL] Remove zookeeper service discovery code in thrift-server#12780
rxin wants to merge 2 commits intoapache:masterfrom
rxin:SPARK-15004

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Apr 29, 2016

What changes were proposed in this pull request?

We recently inlined Hive's thrift server code in SPARK-15004. This patch removes the code related to zookeeper service discovery, Tez, and Hive on Spark, since they are irrelevant.

How was this patch tested?

N/A - removing dead code

@rxin
Copy link
Contributor Author

rxin commented Apr 29, 2016

cc @davies

@SparkQA
Copy link

SparkQA commented Apr 29, 2016

Test build #57345 has finished for PR 12780 at commit 524bc25.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 29, 2016

Test build #57353 has finished for PR 12780 at commit 58f925a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@davies
Copy link
Contributor

davies commented Apr 29, 2016

@rxin The zookeeper things is actually useful for HA or load balancing. If we really want to remove it, this looks good to me.

@rxin
Copy link
Contributor Author

rxin commented Apr 29, 2016

Merging this. Thanks.

@asfgit asfgit closed this in 8ebae46 Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants