[SPARK-13786][ML][PYTHON] Removed save/load for python tuning#12782
Closed
jkbradley wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-13786][ML][PYTHON] Removed save/load for python tuning#12782jkbradley wants to merge 1 commit intoapache:masterfrom
jkbradley wants to merge 1 commit intoapache:masterfrom
Conversation
a91f39e to
d70bfcb
Compare
Member
Author
|
Rebased to fix conflicts |
|
Test build #57352 has finished for PR 12782 at commit
|
|
Test build #57351 has finished for PR 12782 at commit
|
d70bfcb to
6df120f
Compare
Member
Author
|
Rebased to fix apparent unclean merge |
|
Test build #57361 has finished for PR 12782 at commit
|
Member
Author
|
@yinxusen Would you mind taking a look? Thank you! |
| from pyspark.ml import Estimator, Model, Pipeline, PipelineModel, Transformer | ||
| from pyspark.ml.classification import ( | ||
| LogisticRegression, DecisionTreeClassifier, OneVsRest, OneVsRestModel) | ||
| from pyspark.ml.classification import * |
Contributor
There was a problem hiding this comment.
do you need to have a wildcard import?
Member
Author
There was a problem hiding this comment.
There are ~5 imports, so I think it's worthwhile.
Contributor
|
@jkbradley this looks good to me |
Contributor
|
Merged into master. Thanks! |
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Per discussion on [https://github.com//pull/12604], this removes ML persistence for Python tuning (TrainValidationSplit, CrossValidator, and their Models) since they do not handle nesting easily. This support should be re-designed and added in the next release.
How was this patch tested?
Removed unit test elements saving and loading the tuning algorithms, but kept tests to save and load their bestModel fields.