Skip to content

Conversation

@cloud-fan
Copy link
Contributor

What changes were proposed in this pull request?

This is caused by #12776, which removes the synchronized from all methods in AccumulatorContext.

However, a test in CachedTableSuite synchronize on AccumulatorContext and expecting no one else can change it, which is not true anymore.

This PR update that test to not require to lock on AccumulatorContext.

How was this patch tested?

N/A

@cloud-fan
Copy link
Contributor Author

cc @yhuai @rxin

@SparkQA
Copy link

SparkQA commented Apr 30, 2016

Test build #57428 has finished for PR 12811 at commit 1a5234e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Apr 30, 2016

Test build #57437 has finished for PR 12811 at commit 1a5234e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 30, 2016

Test build #2952 has finished for PR 12811 at commit 1a5234e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 30, 2016

Test build #2951 has finished for PR 12811 at commit 1a5234e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 30, 2016

Test build #2953 has finished for PR 12811 at commit 1a5234e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented May 1, 2016

Merging in master.

@asfgit asfgit closed this in 90787de May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants