Skip to content

[SPARK-14973][ML] The CrossValidator and TrainValidationSplit miss the seed when saving and loading#12825

Closed
yinxusen wants to merge 1 commit intoapache:masterfrom
yinxusen:SPARK-14973
Closed

[SPARK-14973][ML] The CrossValidator and TrainValidationSplit miss the seed when saving and loading#12825
yinxusen wants to merge 1 commit intoapache:masterfrom
yinxusen:SPARK-14973

Conversation

@yinxusen
Copy link
Contributor

@yinxusen yinxusen commented May 1, 2016

What changes were proposed in this pull request?

https://issues.apache.org/jira/browse/SPARK-14973

Add seed support when saving/loading of CrossValidator and TrainValidationSplit.

How was this patch tested?

Spark unit test.

@SparkQA
Copy link

SparkQA commented May 1, 2016

Test build #57487 has finished for PR 12825 at commit 235436e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yinxusen
Copy link
Contributor Author

yinxusen commented May 1, 2016

@jkbradley

@HyukjinKwon
Copy link
Member

HyukjinKwon commented May 2, 2016

(@yinxusen i think it would be great if the PR description is fill up and even nicer if the title contains components)

@yinxusen yinxusen changed the title [SPARK-14973] The CrossValidator and TrainValidationSplit miss the seed when saving and loading [SPARK-14973][ML] The CrossValidator and TrainValidationSplit miss the seed when saving and loading May 2, 2016
@jkbradley
Copy link
Member

This LGTM
Thanks @yinxusen !
Merging with master and branch-2.0

asfgit pushed a commit that referenced this pull request May 3, 2016
…e seed when saving and loading

## What changes were proposed in this pull request?

https://issues.apache.org/jira/browse/SPARK-14973

Add seed support when saving/loading of CrossValidator and TrainValidationSplit.

## How was this patch tested?

Spark unit test.

Author: yinxusen <yinxusen@gmail.com>

Closes #12825 from yinxusen/SPARK-14973.

(cherry picked from commit 2e2a621)
Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
@asfgit asfgit closed this in 2e2a621 May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants