[SPARK-15054] Deprecate old accumulator API #12832
Conversation
|
cc @cloud-fan |
|
Test build #57502 has finished for PR 12832 at commit
|
|
LGTM |
## What changes were proposed in this pull request? This patch deprecates the old accumulator API. ## How was this patch tested? N/A Author: Reynold Xin <rxin@databricks.com> Closes #12832 from rxin/SPARK-15054. (cherry picked from commit d5c79f5) Signed-off-by: Reynold Xin <rxin@databricks.com>
| * @tparam R the full accumulated data (result type) | ||
| * @tparam T partial data that can be added in | ||
| */ | ||
| @deprecated("use AccumulatorV2", "2.0.0") |
There was a problem hiding this comment.
@rxin PS I think the JavaSparkContext needs similar treatment? methods like intAccumulator return the old API object.
There was a problem hiding this comment.
yup we need to tweak the scala api a little bit. We can deprecate and create the Java APIs once the Scala done is finalized. I have a ticket for that.
There was a problem hiding this comment.
OK, I'm making another PR to try to fix build warnings. Deprecating these methods actually makes many warnings go away (since deprecated methods calling deprecated methods is OK). Is that much OK to do or don't touch it for now? these methods are going to stay but be deprecated in any event right?
There was a problem hiding this comment.
Wait for one more week?
There was a problem hiding this comment.
NP I'm not in a hurry. Just want to do one more cleanup of build warnings before 2.0.
4 participants
What changes were proposed in this pull request?
This patch deprecates the old accumulator API.
How was this patch tested?
N/A