Skip to content

[SPARK-15150][EXAMPLE][DOC] Update LDA examples#12927

Closed
zhengruifeng wants to merge 13 commits intoapache:masterfrom
zhengruifeng:lda_pe
Closed

[SPARK-15150][EXAMPLE][DOC] Update LDA examples#12927
zhengruifeng wants to merge 13 commits intoapache:masterfrom
zhengruifeng:lda_pe

Conversation

@zhengruifeng
Copy link
Contributor

@zhengruifeng zhengruifeng commented May 5, 2016

What changes were proposed in this pull request?

1,create a libsvm-type dataset for lda: data/mllib/sample_lda_libsvm_data.txt
2,add python example
3,directly read the datafile in examples
4,BTW, change to SparkSession in aft_survival_regression.py

How was this patch tested?

manual tests
./bin/spark-submit examples/src/main/python/ml/lda_example.py

@SparkQA
Copy link

SparkQA commented May 5, 2016

Test build #57865 has finished for PR 12927 at commit b98ad7c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 5, 2016

Test build #57867 has finished for PR 12927 at commit 543df2f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented May 5, 2016

@dongjoon-hyun Sorry for cc a lot but it would be great if I can hear your thoughts. I saw your PRs fixing some examples with the component [EXAMPLE] in the title.

@zhengruifeng zhengruifeng changed the title [SPARK-15150][DOC] Add python example for LDA [SPARK-15150][EXAMPLE] Add python example for LDA May 5, 2016
@zhengruifeng zhengruifeng changed the title [SPARK-15150][EXAMPLE] Add python example for LDA [SPARK-15150][EXAMPLE][DOC] Add python example for LDA May 6, 2016
@SparkQA
Copy link

SparkQA commented May 6, 2016

Test build #57968 has finished for PR 12927 at commit 2270148.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

println(s"The lower bound on the log likelihood of the entire corpus: $ll")
println(s"The upper bound bound on perplexity: $lp")

@SparkQA
Copy link

SparkQA commented May 6, 2016

Test build #57991 has finished for PR 12927 at commit d7916b4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 8, 2016

Test build #58088 has finished for PR 12927 at commit 8625754.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 8, 2016

Test build #58089 has finished for PR 12927 at commit 0191d6a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zhengruifeng zhengruifeng changed the title [SPARK-15150][EXAMPLE][DOC] Add python example for LDA [SPARK-15150][EXAMPLE][DOC] Update LDA examples May 8, 2016
@SparkQA
Copy link

SparkQA commented May 8, 2016

Test build #58101 has finished for PR 12927 at commit 5e26019.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 8, 2016

Test build #58102 has finished for PR 12927 at commit 1219ca1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 11, 2016

Test build #58316 has finished for PR 12927 at commit 65dd7ca.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 11, 2016

Test build #58317 has finished for PR 12927 at commit eab9511.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 11, 2016

Test build #58329 has finished for PR 12927 at commit eab9511.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Describe topics

@MLnick
Copy link
Contributor

MLnick commented May 11, 2016

minor comment on some comments, otherwise LGTM. @yanboliang ?

@SparkQA
Copy link

SparkQA commented May 11, 2016

Test build #58345 has finished for PR 12927 at commit f573fa6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MLnick
Copy link
Contributor

MLnick commented May 11, 2016

Please rebase your PR to current master and fix merge conflicts

@SparkQA
Copy link

SparkQA commented May 11, 2016

Test build #58356 has finished for PR 12927 at commit 83918d4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yanboliang
Copy link
Contributor

LGTM. Thanks!

@MLnick
Copy link
Contributor

MLnick commented May 11, 2016

Merged to master and branch-2.0. Thanks!

asfgit pushed a commit that referenced this pull request May 11, 2016
## What changes were proposed in this pull request?
1,create a libsvm-type dataset for lda: `data/mllib/sample_lda_libsvm_data.txt`
2,add python example
3,directly read the datafile in examples
4,BTW, change to `SparkSession` in `aft_survival_regression.py`

## How was this patch tested?
manual tests
`./bin/spark-submit examples/src/main/python/ml/lda_example.py`

Author: Zheng RuiFeng <ruifengz@foxmail.com>

Closes #12927 from zhengruifeng/lda_pe.

(cherry picked from commit d88afab)
Signed-off-by: Nick Pentreath <nickp@za.ibm.com>
@asfgit asfgit closed this in d88afab May 11, 2016
@zhengruifeng zhengruifeng deleted the lda_pe branch May 11, 2016 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants