[SQL]Update MultiInstanceRelation.scala#1312
Closed
baishuo wants to merge 1 commit intoapache:masterfrom
baishuo:test-1
Closed
[SQL]Update MultiInstanceRelation.scala#1312baishuo wants to merge 1 commit intoapache:masterfrom baishuo:test-1
baishuo wants to merge 1 commit intoapache:masterfrom
baishuo:test-1
Conversation
I think if multiAppearance is empty,we can return plan directly
|
Can one of the admins verify this patch? |
Contributor
Author
|
Can one of the admins verify this patch?:) |
Contributor
|
I think this patch is correct, but I'm not convinced that we need to make these kind of optimizations at the expense of code complexity / length. I'd imagine the performance benefit of this change is negligible and AFAICT it produces the same result as the original code. |
Contributor
|
Also, for future reference there are several stylistic issues:
|
Contributor
Author
|
thank you @marmbrus , close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think if multiAppearance is empty,we can return plan directly