[SPARK-15357] Cooperative spilling should check consumer memory mode#13151
Closed
davies wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-15357] Cooperative spilling should check consumer memory mode#13151davies wants to merge 4 commits intoapache:masterfrom
davies wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
cc @andrewor14 |
|
Test build #58710 has finished for PR 13151 at commit
|
|
Test build #58714 has finished for PR 13151 at commit
|
|
Test build #58719 has finished for PR 13151 at commit
|
| // Call spill() on other consumers to release memory | ||
| for (MemoryConsumer c: consumers) { | ||
| if (c != consumer && c.getUsed() > 0) { | ||
| if (c != consumer && c.getUsed() > 0 && c.getMode() == mode) { |
Contributor
|
LGTM feel free to merge it |
Contributor
Author
|
Merging this into master and 2.0, thanks! |
asfgit
pushed a commit
that referenced
this pull request
May 18, 2016
## What changes were proposed in this pull request? Since we support forced spilling for Spillable, which only works in OnHeap mode, different from other SQL operators (could be OnHeap or OffHeap), we should considering the mode of consumer before calling trigger forced spilling. ## How was this patch tested? Add new test. Author: Davies Liu <davies@databricks.com> Closes #13151 from davies/fix_mode. (cherry picked from commit 8fb1d1c) Signed-off-by: Davies Liu <davies.liu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since we support forced spilling for Spillable, which only works in OnHeap mode, different from other SQL operators (could be OnHeap or OffHeap), we should considering the mode of consumer before calling trigger forced spilling.
How was this patch tested?
Add new test.