[SPARK-15454][SQL] Filter out files starting with _ #13227
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @liancheng and @marmbrus |
|
Test build #59017 has finished for PR 13227 at commit
|
Contributor
|
LGTM, pending tests. |
| // because Parquet needs to find those metadata files from leaf files returned by this method. | ||
| // We should refactor this logic to not mix metadata files with data files. | ||
| (pathName.startsWith("_") || pathName.startsWith(".")) && | ||
| !pathName.startsWith("_common_metadata") && !pathName.startsWith("_metadata") |
Contributor
There was a problem hiding this comment.
Why startsWith instead of == here?
Contributor
Author
There was a problem hiding this comment.
just in case we do other variants here ..
Contributor
|
LGTM except for one minor comment. |
|
Test build #59020 has finished for PR 13227 at commit
|
Contributor
Author
|
Merging in master/2.0. Thanks. |
asfgit
pushed a commit
that referenced
this pull request
May 20, 2016
## What changes were proposed in this pull request? Many other systems (e.g. Impala) uses _xxx as staging, and Spark should not be reading those files. ## How was this patch tested? Added a unit test case. Author: Reynold Xin <rxin@databricks.com> Closes #13227 from rxin/SPARK-15454. (cherry picked from commit dcac8e6) Signed-off-by: Reynold Xin <rxin@databricks.com>
|
Test build #59018 has finished for PR 13227 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Many other systems (e.g. Impala) uses _xxx as staging, and Spark should not be reading those files.
How was this patch tested?
Added a unit test case.