[SPARK-15555] [Mesos] Driver with --supervise option cannot be killed in Mesos mode#13323
Closed
devaraj-kavali wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-15555] [Mesos] Driver with --supervise option cannot be killed in Mesos mode#13323devaraj-kavali wants to merge 4 commits intoapache:masterfrom
devaraj-kavali wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
|
Nice catch, can you add a unit test to test this? |
Contributor
|
ok to test |
|
Test build #59855 has finished for PR 13323 at commit
|
|
Test build #60231 has finished for PR 13323 at commit
|
Author
|
@tnachen Thanks for your review, I have added a test for this, can you have a look into it? |
Contributor
|
Thanks @devaraj-kavali, this LGTM. @andrewor14 can you take a look? |
|
Test build #63276 has finished for PR 13323 at commit
|
Contributor
|
@devaraj-kavali do you mind fixing the conflicts? |
|
Test build #70647 has finished for PR 13323 at commit
|
Contributor
|
Merging to master. |
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Jan 4, 2017
…in Mesos mode ## What changes were proposed in this pull request? Not adding the Killed applications for retry. ## How was this patch tested? I have verified manually in the Mesos cluster, with the changes the killed applications move to Finished Drivers section and will not retry. Author: Devaraj K <devaraj@apache.org> Closes apache#13323 from devaraj-kavali/SPARK-15555.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…in Mesos mode ## What changes were proposed in this pull request? Not adding the Killed applications for retry. ## How was this patch tested? I have verified manually in the Mesos cluster, with the changes the killed applications move to Finished Drivers section and will not retry. Author: Devaraj K <devaraj@apache.org> Closes apache#13323 from devaraj-kavali/SPARK-15555.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Not adding the Killed applications for retry.
How was this patch tested?
I have verified manually in the Mesos cluster, with the changes the killed applications move to Finished Drivers section and will not retry.