[SPARK-15594][SQL] ALTER TABLE SERDEPROPERTIES does not respect partition spec#13343
Closed
andrewor14 wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-15594][SQL] ALTER TABLE SERDEPROPERTIES does not respect partition spec#13343andrewor14 wants to merge 3 commits intoapache:masterfrom
andrewor14 wants to merge 3 commits intoapache:masterfrom
Conversation
|
Test build #59440 has finished for PR 13343 at commit
|
| } | ||
| // set serde properties only | ||
| sql("ALTER TABLE dbx.tab1 PARTITION (a=1, b=2) " + | ||
| "SET SERDEPROPERTIES ('k' = 'vvv', 'kay' = 'vee')") |
Contributor
There was a problem hiding this comment.
Do data source tables allow this?
Contributor
Author
There was a problem hiding this comment.
right now they do. Should they not?
Contributor
There was a problem hiding this comment.
For data source tables, seems we do not store any partition specs. I am wondering why metastore does not complain?
Contributor
Author
There was a problem hiding this comment.
ah I see. We can add 1 more check
|
Test build #59522 has finished for PR 13343 at commit
|
Contributor
|
lgtm. Merging to master and branch 2.0. |
asfgit
pushed a commit
that referenced
this pull request
May 28, 2016
…tion spec
## What changes were proposed in this pull request?
These commands ignore the partition spec and change the storage properties of the table itself:
```
ALTER TABLE table_name PARTITION (a=1, b=2) SET SERDE 'my_serde'
ALTER TABLE table_name PARTITION (a=1, b=2) SET SERDEPROPERTIES ('key1'='val1')
```
Now they change the storage properties of the specified partition.
## How was this patch tested?
DDLSuite
Author: Andrew Or <andrew@databricks.com>
Closes #13343 from andrewor14/alter-table-serdeproperties.
(cherry picked from commit 4a2fb8b)
Signed-off-by: Yin Huai <yhuai@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
These commands ignore the partition spec and change the storage properties of the table itself:
Now they change the storage properties of the specified partition.
How was this patch tested?
DDLSuite