[SPARK-15112][SQL] Disables EmbedSerializerInFilter for plan fragments that change schema#13362
Closed
liancheng wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-15112][SQL] Disables EmbedSerializerInFilter for plan fragments that change schema#13362liancheng wants to merge 2 commits intoapache:masterfrom
liancheng wants to merge 2 commits intoapache:masterfrom
Conversation
liancheng
force-pushed
the
spark-15112-corrupted-filter
branch
from
7091e65 to
5b8362a
Compare
Contributor
Author
|
cc @cloud-fan |
liancheng
changed the title
Contributor
|
LGTM |
|
Test build #59520 has finished for PR 13362 at commit
|
|
Test build #59556 has finished for PR 13362 at commit
|
liancheng
force-pushed
the
spark-15112-corrupted-filter
branch
from
edce7a6 to
4099d69
Compare
|
Test build #59563 has finished for PR 13362 at commit
|
Contributor
Author
|
Merging to master and branch-2.0. Thanks for the review! |
asfgit
pushed a commit
that referenced
this pull request
May 30, 2016
…s that change schema ## What changes were proposed in this pull request? `EmbedSerializerInFilter` implicitly assumes that the plan fragment being optimized doesn't change plan schema, which is reasonable because `Dataset.filter` should never change the schema. However, due to another issue involving `DeserializeToObject` and `SerializeFromObject`, typed filter *does* change plan schema (see [SPARK-15632][1]). This breaks `EmbedSerializerInFilter` and causes corrupted data. This PR disables `EmbedSerializerInFilter` when there's a schema change to avoid data corruption. The schema change issue should be addressed in follow-up PRs. ## How was this patch tested? New test case added in `DatasetSuite`. [1]: https://issues.apache.org/jira/browse/SPARK-15632 Author: Cheng Lian <lian@databricks.com> Closes #13362 from liancheng/spark-15112-corrupted-filter. (cherry picked from commit 1360a6d) Signed-off-by: Cheng Lian <lian@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
EmbedSerializerInFilterimplicitly assumes that the plan fragment being optimized doesn't change plan schema, which is reasonable becauseDataset.filtershould never change the schema.However, due to another issue involving
DeserializeToObjectandSerializeFromObject, typed filter does change plan schema (see SPARK-15632). This breaksEmbedSerializerInFilterand causes corrupted data.This PR disables
EmbedSerializerInFilterwhen there's a schema change to avoid data corruption. The schema change issue should be addressed in follow-up PRs.How was this patch tested?
New test case added in
DatasetSuite.