Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented May 27, 2016

What changes were proposed in this pull request?

This is a simple patch that makes package names for Java 8 test suites consistent. I moved everything to test.org.apache.spark to we can test package private APIs properly. Also added "java8" as the package name so we can easily run all the tests related to Java 8.

How was this patch tested?

This is a test only change.

@rxin
Copy link
Contributor Author

rxin commented May 27, 2016

cc @andrewor14

*/

package org.apache.spark;
package test.org.apache.spark.java8;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, core tests use test.org.apache.spark to specifically test from outside the same package. Is .java8 needed? I don't particularly care much myself. Some scala tests use org.apache.sparktest, unfortunately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the java8 part is to make it easier to run all java 8 tests. not that big of a deal though. the more important one is to make the beginning part consistent.

@SparkQA
Copy link

SparkQA commented May 27, 2016

Test build #59527 has finished for PR 13364 at commit f44883f.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public class Java8RDDAPISuite implements Serializable
    • public class Java8APISuite extends LocalJavaStreamingContext implements Serializable
    • public class Java8DatasetAggregatorSuite extends JavaDatasetAggregatorSuiteBase
    • class JDK8ScalaSuite extends SparkFunSuite with SharedSparkContext
    • public class JavaDatasetAggregatorSuite extends JavaDatasetAggregatorSuiteBase
    • static class IntSumOf extends Aggregator<Tuple2<String, Integer>, Integer, Integer>
    • public class JavaDatasetAggregatorSuiteBase implements Serializable
    • public class JavaSaveLoadSuite

@SparkQA
Copy link

SparkQA commented May 28, 2016

Test build #3029 has finished for PR 13364 at commit f44883f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public class Java8RDDAPISuite implements Serializable
    • public class Java8APISuite extends LocalJavaStreamingContext implements Serializable
    • public class Java8DatasetAggregatorSuite extends JavaDatasetAggregatorSuiteBase
    • class JDK8ScalaSuite extends SparkFunSuite with SharedSparkContext
    • public class JavaDatasetAggregatorSuite extends JavaDatasetAggregatorSuiteBase
    • static class IntSumOf extends Aggregator<Tuple2<String, Integer>, Integer, Integer>
    • public class JavaDatasetAggregatorSuiteBase implements Serializable
    • public class JavaSaveLoadSuite

@rxin
Copy link
Contributor Author

rxin commented May 28, 2016

Merging in master/2.0.

asfgit pushed a commit that referenced this pull request May 28, 2016
## What changes were proposed in this pull request?
This is a simple patch that makes package names for Java 8 test suites consistent. I moved everything to test.org.apache.spark to we can test package private APIs properly. Also added "java8" as the package name so we can easily run all the tests related to Java 8.

## How was this patch tested?
This is a test only change.

Author: Reynold Xin <rxin@databricks.com>

Closes #13364 from rxin/SPARK-15633.

(cherry picked from commit 73178c7)
Signed-off-by: Reynold Xin <rxin@databricks.com>
@asfgit asfgit closed this in 73178c7 May 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants