Skip to content

[CORE][MINOR][DOC] Removing incorrect scaladoc#13384

Closed
jaceklaskowski wants to merge 1 commit intoapache:masterfrom
jaceklaskowski:blockinfomanager
Closed

[CORE][MINOR][DOC] Removing incorrect scaladoc#13384
jaceklaskowski wants to merge 1 commit intoapache:masterfrom
jaceklaskowski:blockinfomanager

Conversation

@jaceklaskowski
Copy link
Contributor

What changes were proposed in this pull request?

I don't think the method will ever throw an exception so removing a false comment. Sorry @srowen and @rxin again -- I simply couldn't resist.

I wholeheartedly support merging the change with a bigger one (and trashing this PR).

How was this patch tested?

Manual build

@SparkQA
Copy link

SparkQA commented May 28, 2016

Test build #59567 has finished for PR 13384 at commit 7c029d6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

Looks like that logic is removed in #13082 and we forgot to update the doc. LGTM

@srowen
Copy link
Member

srowen commented Jun 1, 2016

Merged to master/2.0

asfgit pushed a commit that referenced this pull request Jun 1, 2016
## What changes were proposed in this pull request?

I don't think the method will ever throw an exception so removing a false comment. Sorry srowen and rxin again -- I simply couldn't resist.

I wholeheartedly support merging the change with a bigger one (and trashing this PR).

## How was this patch tested?

Manual build

Author: Jacek Laskowski <jacek@japila.pl>

Closes #13384 from jaceklaskowski/blockinfomanager.

(cherry picked from commit 6954704)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@asfgit asfgit closed this in 6954704 Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants