-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-15645][Streaming] Fix some typos of Streaming module #13385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,13 +86,13 @@ private[streaming] class BlockGenerator( | |
| /** | ||
| * The BlockGenerator can be in 5 possible states, in the order as follows. | ||
| * | ||
| * - Initialized: Nothing has been started | ||
| * - Initialized: Nothing has been started. | ||
| * - Active: start() has been called, and it is generating blocks on added data. | ||
| * - StoppedAddingData: stop() has been called, the adding of data has been stopped, | ||
| * but blocks are still being generated and pushed. | ||
| * - StoppedGeneratingBlocks: Generating of blocks has been stopped, but | ||
| * they are still being pushed. | ||
| * - StoppedAll: Everything has stopped, and the BlockGenerator object can be GCed. | ||
| * - StoppedAll: Everything has been stopped, and the BlockGenerator object can be GCed. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a typo, but does make the voice consistent. OK |
||
| */ | ||
| private object GeneratorState extends Enumeration { | ||
| type GeneratorState = Value | ||
|
|
@@ -148,7 +148,7 @@ private[streaming] class BlockGenerator( | |
| blockIntervalTimer.stop(interruptTimer = false) | ||
| synchronized { state = StoppedGeneratingBlocks } | ||
|
|
||
| // Wait for the queue to drain and mark generated as stopped | ||
| // Wait for the queue to drain and mark state as StoppedAll | ||
| logInfo("Waiting for block pushing thread to terminate") | ||
| blockPushingThread.join() | ||
| synchronized { state = StoppedAll } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a typo, I'd revert it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't
extends Partition with Serializable {should be 2-indent instead of 4-indent?I see many of similar style where 2-indent is used https://github.com/apache/spark/blob/master/streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala#L63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on master branch https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/rdd/ParallelCollectionRDD.scala#L36
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see your point, it is really about the indentation, and that's why the paren is wrapped. OK.