SPARK-15641 HistoryServer to not show invalid date for incomplete application #13396
Conversation
|
|
||
| function formatDate(date) { | ||
| return date.split(".")[0].replace("T", " "); | ||
| if (date <= 0) return "-"; |
There was a problem hiding this comment.
I suppose I don't have a preference on "" vs "-". LGTM
There was a problem hiding this comment.
How about using "n/a" which would specifically indicate that its invalid to expect the end time ?
There was a problem hiding this comment.
shrug I think blank or - is simpler and more general. I guess n/a takes a moment to parse as not applicable.
There was a problem hiding this comment.
How about I spell it out as "Not available"? blank or "-" seems not very informative to the users.
There was a problem hiding this comment.
I personally think that just adds more noise to the screen. Sometimes the column value is a date, sometimes a text string then. Using a blank is the most natural "no value" to me.
There was a problem hiding this comment.
I see. But to me, blank indicates that something is wrong. "-" is a little better. So I changed it back to "-".
|
Jenkins test this please |
|
nit: the title of the PR could be made better:
|
catapan
changed the title
|
revised as suggested. Thanks for the suggestions. |
|
Test build #59599 has finished for PR 13396 at commit
|
This reverts commit add3cf6.
|
Merged to master/2.0 |
…pplication ## What changes were proposed in this pull request? For incomplete applications in HistoryServer, the complete column will show "-" instead of incorrect date. ## How was this patch tested? manually tested. Author: catapan <cedarpan86@gmail.com> Author: Ziying Pan <cedarpan@Ziyings-MacBook.local> Closes #13396 from catapan/SPARK-15641_fix_completed_column. (cherry picked from commit 6878f3e) Signed-off-by: Sean Owen <sowen@cloudera.com>
4 participants
What changes were proposed in this pull request?
For incomplete applications in HistoryServer, the complete column will show "-" instead of incorrect date.
How was this patch tested?
manually tested.