Skip to content

[SPARK-15596][SPARK-15635][SQL] ALTER TABLE RENAME fixes#13416

Closed
andrewor14 wants to merge 3 commits intoapache:masterfrom
andrewor14:rename-table
Closed

[SPARK-15596][SPARK-15635][SQL] ALTER TABLE RENAME fixes#13416
andrewor14 wants to merge 3 commits intoapache:masterfrom
andrewor14:rename-table

Conversation

@andrewor14
Copy link
Contributor

What changes were proposed in this pull request?

SPARK-15596: Even after we renamed a cached table, the plan would remain in the cache with the old table name. If I created a new table using the old name then the old table would return incorrect data. Note that this applies only to Hive tables.

SPARK-15635: Renaming a datasource table would render the table not query-able. This is because we store the location of the table in a "path" property, which was not updated to reflect Hive's change in table location following a rename.

How was this patch tested?

DDLSuite

@SparkQA
Copy link

SparkQA commented May 31, 2016

Test build #59665 has finished for PR 13416 at commit 68b0d35.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented May 31, 2016

Test build #59675 has finished for PR 13416 at commit 68b0d35.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor Author

@yhuai

@yhuai
Copy link
Contributor

yhuai commented Jun 1, 2016

lgtm

@yhuai
Copy link
Contributor

yhuai commented Jun 1, 2016

merging to master and branch 2.0

asfgit pushed a commit that referenced this pull request Jun 1, 2016
## What changes were proposed in this pull request?

**SPARK-15596**: Even after we renamed a cached table, the plan would remain in the cache with the old table name. If I created a new table using the old name then the old table would return incorrect data. Note that this applies only to Hive tables.

**SPARK-15635**: Renaming a datasource table would render the table not query-able. This is because we store the location of the table in a "path" property, which was not updated to reflect Hive's change in table location following a rename.

## How was this patch tested?

DDLSuite

Author: Andrew Or <andrew@databricks.com>

Closes #13416 from andrewor14/rename-table.

(cherry picked from commit 9e2643b)
Signed-off-by: Yin Huai <yhuai@databricks.com>
@asfgit asfgit closed this in 9e2643b Jun 1, 2016
@andrewor14 andrewor14 deleted the rename-table branch June 1, 2016 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants