[SPARK-14279][BUILD] Pick the spark version from pom#13530
[SPARK-14279][BUILD] Pick the spark version from pom#13530dhruve wants to merge 1 commit intoapache:branch-2.0from
Conversation
| // For package docs only | ||
| val SPARK_VERSION = "2.0.0-preview" | ||
|
|
||
| private object SparkBuildInfo { |
There was a problem hiding this comment.
With the current state being in the preview mode, users testing the framework would see the version as 2.0.0-SNAPSHOT as being mentioned in the pom file.
If this is acceptable, rest of the changes are as is.
|
hm maybe no need to do this for branch-2.0, since it's pretty easy to do this manually once or twice for 2.0.x. |
|
Dhruve points out above an instance where a previous release wasn't properly changed and now Spark is printing the wrong version in branch-2.0; so I think this change does help. |
|
ok to test |
|
Test build #60073 has finished for PR 13530 at commit
|
|
Personally I would like to see this go into branch-2.0 also. it doesn't seem very risky but has benefits to both dev and end users. @rxin do you have strong objections? |
|
sounds good go ahead |
|
Merging to 2.0. |
Changes are already merged in master (#13061) . This one's for branch-2.0 Author: Dhruve Ashar <dhruveashar@gmail.com> Closes #13530 from dhruve/impr/branch-2.0/SPARK-14279.
|
@dhruve could you close the PR? The bot doesn't do it automatically for backports. thx |
|
@vanzin. Thanks for reviewing & merging the PR. Have closed it. |
|
|
|
@chenghao-intel can you file a jira with the details on what you are doing and link to the original jira? |
Changes are already merged in master (#13061) . This one's for branch-2.0