Skip to content

[SPARK-14279][BUILD] Pick the spark version from pom#13530

Closed
dhruve wants to merge 1 commit intoapache:branch-2.0from
dhruve:impr/branch-2.0/SPARK-14279
Closed

[SPARK-14279][BUILD] Pick the spark version from pom#13530
dhruve wants to merge 1 commit intoapache:branch-2.0from
dhruve:impr/branch-2.0/SPARK-14279

Conversation

@dhruve
Copy link
Contributor

@dhruve dhruve commented Jun 6, 2016

Changes are already merged in master (#13061) . This one's for branch-2.0

// For package docs only
val SPARK_VERSION = "2.0.0-preview"

private object SparkBuildInfo {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanzin

With the current state being in the preview mode, users testing the framework would see the version as 2.0.0-SNAPSHOT as being mentioned in the pom file.

If this is acceptable, rest of the changes are as is.

@rxin
Copy link
Contributor

rxin commented Jun 6, 2016

hm maybe no need to do this for branch-2.0, since it's pretty easy to do this manually once or twice for 2.0.x.

@vanzin
Copy link
Contributor

vanzin commented Jun 6, 2016

Dhruve points out above an instance where a previous release wasn't properly changed and now Spark is printing the wrong version in branch-2.0; so I think this change does help.

@vanzin
Copy link
Contributor

vanzin commented Jun 6, 2016

ok to test

@SparkQA
Copy link

SparkQA commented Jun 6, 2016

Test build #60073 has finished for PR 13530 at commit 9c14834.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tgravescs
Copy link
Contributor

Personally I would like to see this go into branch-2.0 also. it doesn't seem very risky but has benefits to both dev and end users. @rxin do you have strong objections?

@rxin
Copy link
Contributor

rxin commented Jun 7, 2016

sounds good go ahead

@vanzin
Copy link
Contributor

vanzin commented Jun 7, 2016

Merging to 2.0.

asfgit pushed a commit that referenced this pull request Jun 7, 2016
Changes are already merged in master (#13061) . This one's for branch-2.0

Author: Dhruve Ashar <dhruveashar@gmail.com>

Closes #13530 from dhruve/impr/branch-2.0/SPARK-14279.
@vanzin
Copy link
Contributor

vanzin commented Jun 7, 2016

@dhruve could you close the PR? The bot doesn't do it automatically for backports. thx

@dhruve
Copy link
Contributor Author

dhruve commented Jun 8, 2016

@vanzin. Thanks for reviewing & merging the PR. Have closed it.

@dhruve dhruve closed this Jun 8, 2016
@chenghao-intel
Copy link
Contributor

spark-version-info.properties cannot be found in my develop machine, and will cause NPE while debugging with IDE, should we add the default version info back for developers like me?

@tgravescs
Copy link
Contributor

@chenghao-intel can you file a jira with the details on what you are doing and link to the original jira?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants