[SPARK-15823][PySpark][ML] Add @property for 'accuracy' in MulticlassMetrics#13560
Closed
zhengruifeng wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-15823][PySpark][ML] Add @property for 'accuracy' in MulticlassMetrics#13560zhengruifeng wants to merge 2 commits intoapache:masterfrom
zhengruifeng wants to merge 2 commits intoapache:masterfrom
Conversation
|
Test build #60166 has finished for PR 13560 at commit
|
zhengruifeng
changed the title
| >>> metrics.recall() | ||
| 0.66... | ||
| >>> metrics.accuracy() | ||
| >>> metrics.accuracy |
Member
There was a problem hiding this comment.
While we're here, maybe we should remove the deprecated calls to recall() and precision() above.
Contributor
Author
There was a problem hiding this comment.
Ok, I will remove those lines
|
Test build #60280 has finished for PR 13560 at commit
|
Member
|
Merged to master/2.0 |
asfgit
pushed a commit
that referenced
this pull request
Jun 10, 2016
…Metrics ## What changes were proposed in this pull request? `accuracy` should be decorated with `property` to keep step with other methods in `pyspark.MulticlassMetrics`, like `weightedPrecision`, `weightedRecall`, etc ## How was this patch tested? manual tests Author: Zheng RuiFeng <ruifengz@foxmail.com> Closes #13560 from zhengruifeng/add_accuracy_property. (cherry picked from commit 16ca32e) Signed-off-by: Sean Owen <sowen@cloudera.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
accuracyshould be decorated with@propertyto keep step with other methods inpyspark.MulticlassMetrics, likeweightedPrecision,weightedRecall, etcHow was this patch tested?
manual tests