[Minor][Doc] In Dataset docs, remove self link to Dataset and add link to Column#13567
Closed
techaddict wants to merge 4 commits intoapache:masterfrom
Closed
[Minor][Doc] In Dataset docs, remove self link to Dataset and add link to Column#13567techaddict wants to merge 4 commits intoapache:masterfrom
techaddict wants to merge 4 commits intoapache:masterfrom
Conversation
|
Test build #60191 has finished for PR 13567 at commit
|
Contributor
|
hm I'm actually not sure whether we always want to link, especially self links given it's already on the same file. |
Contributor
Author
|
@rxin I'm also biased on not doing self-links, but there are already so many self-links on datasets docs So we should either remove those or add these to make everything consistent. |
Contributor
|
Alright do you want to update the pr to remove them instead? |
techaddict
changed the title
Contributor
Author
|
@rxin Done 👍 |
Contributor
|
LGTM pending tests. can you update the title to say "[Minor][Doc] In Dataset docs, remove self link to Dataset and add link to Column" |
techaddict
changed the title
|
Test build #60221 has finished for PR 13567 at commit
|
Contributor
|
Merging in master/2,0. |
zjffdu
pushed a commit
to zjffdu/spark
that referenced
this pull request
Jun 10, 2016
…k to Column ## What changes were proposed in this pull request? Documentation Fix ## How was this patch tested? Author: Sandeep Singh <sandeep@techaddict.me> Closes apache#13567 from techaddict/minor-4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Documentation Fix
How was this patch tested?