Skip to content

[Minor][Doc] Improve SQLContext Documentation and Fix SparkSession and sql.functions Documentation#13577

Closed
techaddict wants to merge 7 commits intoapache:masterfrom
techaddict:minor-5
Closed

[Minor][Doc] Improve SQLContext Documentation and Fix SparkSession and sql.functions Documentation#13577
techaddict wants to merge 7 commits intoapache:masterfrom
techaddict:minor-5

Conversation

@techaddict
Copy link
Contributor

What changes were proposed in this pull request?

  1. In SparkSession, add emptyDataset to dataset group and fix groupname mapping
  2. Add documentation for createDataset for SQLContext
  3. Fix the documentation of months_between in functions

How was this patch tested?

Verified manually by generating api docs using build/sbt spark/scalaunidoc:doc

@SparkQA
Copy link

SparkQA commented Jun 9, 2016

Test build #60233 has finished for PR 13577 at commit 1e05d6d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 9, 2016

Test build #60234 has finished for PR 13577 at commit f0459bc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

* that is generally created automatically through implicits from a `SparkSession`, or can be
* created explicitly by calling static methods on [[Encoders]].
*
* == Example ==
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this look like when it is rendered?

@rxin
Copy link
Contributor

rxin commented Jun 9, 2016

Actually thanks for the pr. Got me to do this one: #13582

asfgit pushed a commit that referenced this pull request Jun 10, 2016
## What changes were proposed in this pull request?
SparkSession does not have that many functions due to better namespacing, and as a result we probably don't need the function grouping. This patch removes the grouping and also adds missing scaladocs for createDataset functions in SQLContext.

Closes #13577.

## How was this patch tested?
N/A - this is a documentation change.

Author: Reynold Xin <rxin@databricks.com>

Closes #13582 from rxin/SPARK-15850.

(cherry picked from commit 16df133)
Signed-off-by: Herman van Hovell <hvanhovell@databricks.com>
@asfgit asfgit closed this in 16df133 Jun 10, 2016
zjffdu pushed a commit to zjffdu/spark that referenced this pull request Jun 10, 2016
## What changes were proposed in this pull request?
SparkSession does not have that many functions due to better namespacing, and as a result we probably don't need the function grouping. This patch removes the grouping and also adds missing scaladocs for createDataset functions in SQLContext.

Closes apache#13577.

## How was this patch tested?
N/A - this is a documentation change.

Author: Reynold Xin <rxin@databricks.com>

Closes apache#13582 from rxin/SPARK-15850.
@techaddict techaddict deleted the minor-5 branch July 4, 2016 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants