[SPARK-14321][SQL] Reduce date format cost and string-to-date cost in date functions #13581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @cloud-fan |
| val formatter = ctx.freshName("formatter") | ||
| if (fString == null) { | ||
| if (formatter == null) { | ||
| ev.copy(code = s""" |
Contributor
There was a problem hiding this comment.
this can be: ev.copy(code = "", isNull = "false", value = ctx.defaultValue(dataType))
Contributor
|
LGTM except a minor comment |
Contributor
|
Tip: if you put "closes #13522" in the PR description then the subsumed PR will be automatically closed once this PR is merged. |
hvanhovell
changed the title
Contributor
@hvanhovell not PR title... |
Contributor
|
LGTM, pending jenkins |
hvanhovell
changed the title
|
Test build #60245 has finished for PR 13581 at commit
|
|
Test build #60247 has finished for PR 13581 at commit
|
Contributor
|
Merging in master/2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 9, 2016
… date functions ## What changes were proposed in this pull request? The current implementations of `UnixTime` and `FromUnixTime` do not cache their parser/formatter as much as they could. This PR resolved this issue. This PR is a take over from #13522 and further optimizes the re-use of the parser/formatter. It also fixes the improves handling (catching the actual exception instead of `Throwable`). All credits for this work should go to rajeshbalamohan. This PR closes #13522 ## How was this patch tested? Current tests. Author: Herman van Hovell <hvanhovell@databricks.com> Author: Rajesh Balamohan <rbalamohan@apache.org> Closes #13581 from hvanhovell/SPARK-14321. (cherry picked from commit b076853) Signed-off-by: Reynold Xin <rxin@databricks.com>
zjffdu
pushed a commit
to zjffdu/spark
that referenced
this pull request
Jun 10, 2016
… date functions ## What changes were proposed in this pull request? The current implementations of `UnixTime` and `FromUnixTime` do not cache their parser/formatter as much as they could. This PR resolved this issue. This PR is a take over from apache#13522 and further optimizes the re-use of the parser/formatter. It also fixes the improves handling (catching the actual exception instead of `Throwable`). All credits for this work should go to rajeshbalamohan. This PR closes apache#13522 ## How was this patch tested? Current tests. Author: Herman van Hovell <hvanhovell@databricks.com> Author: Rajesh Balamohan <rbalamohan@apache.org> Closes apache#13581 from hvanhovell/SPARK-14321.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The current implementations of
UnixTimeandFromUnixTimedo not cache their parser/formatter as much as they could. This PR resolved this issue.This PR is a take over from #13522 and further optimizes the re-use of the parser/formatter. It also fixes the improves handling (catching the actual exception instead of
Throwable). All credits for this work should go to @rajeshbalamohan.This PR closes #13522
How was this patch tested?
Current tests.