[SPARK-15866] Rename listAccumulator collectionAccumulator#13594
Closed
rxin wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-15866] Rename listAccumulator collectionAccumulator#13594rxin wants to merge 1 commit intoapache:masterfrom
rxin wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
cc @cloud-fan |
| * | ||
| * @since 2.0.0 | ||
| */ | ||
| class CollectionAccumulator[T] extends AccumulatorV2[T, java.util.List[T]] { |
Member
There was a problem hiding this comment.
Question: so this method still accumulates a list, despite its name (which does sound better). Can an accumulator guarantee an order to the items add to the list meaningfully? if not, then maybe it should be advertised as an accumulator of a Collection.
Contributor
There was a problem hiding this comment.
the order is preserved for the inputs from same partition, but not among partitions.
|
Test build #60282 has finished for PR 13594 at commit
|
Contributor
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Jun 10, 2016
## What changes were proposed in this pull request? SparkContext.listAccumulator, by Spark's convention, makes it sound like "list" is a verb and the method should return a list of accumulators. This patch renames the method and the class collection accumulator. ## How was this patch tested? Updated test case to reflect the names. Author: Reynold Xin <rxin@databricks.com> Closes #13594 from rxin/SPARK-15866. (cherry picked from commit 254bc8c) Signed-off-by: Reynold Xin <rxin@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SparkContext.listAccumulator, by Spark's convention, makes it sound like "list" is a verb and the method should return a list of accumulators. This patch renames the method and the class collection accumulator.
How was this patch tested?
Updated test case to reflect the names.