[SPARK-15914][SQL] Add deprecated method back to SQLContext for backward source code compatibility#13637
Closed
clockfly wants to merge 5 commits intoapache:masterfrom
Closed
[SPARK-15914][SQL] Add deprecated method back to SQLContext for backward source code compatibility#13637clockfly wants to merge 5 commits intoapache:masterfrom
clockfly wants to merge 5 commits intoapache:masterfrom
Conversation
|
Test build #60387 has finished for PR 13637 at commit
|
clockfly
changed the title
|
Test build #60424 has finished for PR 13637 at commit
|
|
Test build #60425 has finished for PR 13637 at commit
|
| * `read().format(source).schema(schema).options(options).load()`. | ||
| */ | ||
| @deprecated("Use read.format(source).schema(schema).options(options).load() instead.", "1.4.0") | ||
| def load(source: String, schema: StructType, options: java.util.Map[String, String]): DataFrame = |
Contributor
There was a problem hiding this comment.
nit the right style is:
def load(
sources: String,
schema: StructType,
options: ...): DataFrame = {
read.format...
}
Contributor
|
This looks good, just minor commnts |
|
Test build #60433 has finished for PR 13637 at commit
|
|
Test build #60447 has finished for PR 13637 at commit
|
Contributor
|
Thanks. Merging to master and branch 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 14, 2016
…ard source code compatibility ## What changes were proposed in this pull request? Revert partial changes in SPARK-12600, and add some deprecated method back to SQLContext for backward source code compatibility. ## How was this patch tested? Manual test. Author: Sean Zhong <seanzhong@databricks.com> Closes #13637 from clockfly/SPARK-15914. (cherry picked from commit 6e8cdef) Signed-off-by: Yin Huai <yhuai@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Revert partial changes in SPARK-12600, and add some deprecated method back to SQLContext for backward source code compatibility.
How was this patch tested?
Manual test.