[SPARK-15741][PYSPARK][ML] Pyspark cleanup of set default seed to None#13672
Closed
BryanCutler wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-15741][PYSPARK][ML] Pyspark cleanup of set default seed to None#13672BryanCutler wants to merge 3 commits intoapache:masterfrom
BryanCutler wants to merge 3 commits intoapache:masterfrom
Conversation
…etDefault-seed-SPARK-15741 Conflicts: python/pyspark/ml/feature.py
Member
Author
|
@MLnick , does this seem reasonable? |
|
Test build #60520 has finished for PR 13672 at commit
|
Contributor
|
LGTM |
Member
Author
|
Thanks @MLnick , can this be merged or do we need to wait until 2.0 is cut? |
Contributor
|
jenkins retest this please |
|
Test build #60911 has finished for PR 13672 at commit
|
Contributor
|
Merged into master and branch-2.0. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Jun 21, 2016
## What changes were proposed in this pull request? Several places set the seed Param default value to None which will translate to a zero value on the Scala side. This is unnecessary because a default fixed value already exists and if a test depends on a zero valued seed, then it should explicitly set it to zero instead of relying on this translation. These cases can be safely removed except for the ALS doc test, which has been changed to set the seed value to zero. ## How was this patch tested? Ran PySpark tests locally Author: Bryan Cutler <cutlerb@gmail.com> Closes #13672 from BryanCutler/pyspark-cleanup-setDefault-seed-SPARK-15741. (cherry picked from commit b76e355) Signed-off-by: Xiangrui Meng <meng@databricks.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Several places set the seed Param default value to None which will translate to a zero value on the Scala side. This is unnecessary because a default fixed value already exists and if a test depends on a zero valued seed, then it should explicitly set it to zero instead of relying on this translation. These cases can be safely removed except for the ALS doc test, which has been changed to set the seed value to zero.
How was this patch tested?
Ran PySpark tests locally