Skip to content

[SPARK-16017][Core]Send hostname from CoarseGrainedExecutorBackend to driver#13741

Closed
zsxwing wants to merge 1 commit intoapache:masterfrom
zsxwing:SPARK-16017
Closed

[SPARK-16017][Core]Send hostname from CoarseGrainedExecutorBackend to driver#13741
zsxwing wants to merge 1 commit intoapache:masterfrom
zsxwing:SPARK-16017

Conversation

@zsxwing
Copy link
Copy Markdown
Member

@zsxwing zsxwing commented Jun 17, 2016

What changes were proposed in this pull request?

SPARK-15395 changes the behavior that how the driver gets the executor host and the driver will get the executor IP address instead of the host name. This PR just sends the hostname from executors to driver so that driver can pass it to TaskScheduler.

How was this patch tested?

Existing unit tests.

@zsxwing
Copy link
Copy Markdown
Member Author

zsxwing commented Jun 17, 2016

/cc @vanzin

@vanzin
Copy link
Copy Markdown
Contributor

vanzin commented Jun 17, 2016

Code looks ok, but could you run an actual application on HDFS and make sure that tasks are allocated respecting the proper locality?

@zsxwing
Copy link
Copy Markdown
Member Author

zsxwing commented Jun 17, 2016

@vanzin Just tested local-cluster, standalone, yarn-client, and all of them work. The local mode still shows Any locality, however since #13185 and this one won't affect the local mode (LocalScheduler has a different code path), that's an existing issue already and should not block this PR.

@vanzin
Copy link
Copy Markdown
Contributor

vanzin commented Jun 17, 2016

Cool, thanks. LGTM

@SparkQA
Copy link
Copy Markdown

SparkQA commented Jun 17, 2016

Test build #60724 has finished for PR 13741 at commit 50fee0a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Copy Markdown
Member Author

zsxwing commented Jun 17, 2016

Thanks! Merging to master and 2.0.

@asfgit asfgit closed this in 62d8fe2 Jun 17, 2016
asfgit pushed a commit that referenced this pull request Jun 17, 2016
…o driver

## What changes were proposed in this pull request?

[SPARK-15395](https://issues.apache.org/jira/browse/SPARK-15395) changes the behavior that how the driver gets the executor host and the driver will get the executor IP address instead of the host name. This PR just sends the hostname from executors to driver so that driver can pass it to TaskScheduler.

## How was this patch tested?

Existing unit tests.

Author: Shixiong Zhu <shixiong@databricks.com>

Closes #13741 from zsxwing/SPARK-16017.

(cherry picked from commit 62d8fe2)
Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
@zsxwing zsxwing deleted the SPARK-16017 branch June 17, 2016 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants